๐ŸŽ‰ Happy 19th Birthday to Danbooru! ๐ŸŽ‰
Danbooru

Order of images when viewing favorites

Posted under General

I noticed that after the transition to Danbooru v2.2.0, the order of images when I try to view my favorited images is based on upload dates, not the order of my favoriting them. Is there any way to make it so that I can view them in the order I favorited them?

Updated by darklord

Bringing up this issue again: I've gotten used to it by now, but I think it's better for the link from the profile page to lead to the list in the order of adding to favorites. After all, the profile page is the personal one, just like the order of favoriting is. When we try to access favorites from the profile page, we'd usually want to view them in the order we favorited them. Likewise, I think it fits better if the link from the top bar in the posts page (which is public) leads to the posts in the upload order.

Hence I'm submitting a suggestion/request to swap the links. How do the other members think about this?

Lick_King said:

Bringing up this issue again: I've gotten used to it by now, but I think it's better for the link from the profile page to lead to the list in the order of adding to favorites. After all, the profile page is the personal one, just like the order of favoriting is. When we try to access favorites from the profile page, we'd usually want to view them in the order we favorited them. Likewise, I think it fits better if the link from the top bar in the posts page (which is public) leads to the posts in the upload order.

Hence I'm submitting a suggestion/request to swap the links. How do the other members think about this?

The reason it was changed is because /favorites?user_id=id wasn't working. I just fixed that, so I've changed the profile link to point to that instead of fav:name for the next version.

Lick_King said:
Likewise, I think it fits better if the link from the top bar in the posts page (which is public) leads to the posts in the upload order.

I would not call it public, it's arguably even more private than the link in your profile. Any user can see and use that link but it will lead him to his own favs. While link in profile will lead to favs of the user whose profile you are viewing.

Also, current /favorites page is working noticeably faster than "fav:[username]" search, probably because it does not need to calculate number of results. That's another reason why link in the subnavigation bar should remain as is.

@Toks
Favorites were one of the substantial performance issues in Danbooru 1. I don't know how the code has changed, maybe they won't cause any problems now, but you should monitor how changes you make will influence server response time.

MyrMindservant said:

Also, current /favorites page is working noticeably faster than "fav:[username]" search, probably because it does not need to calculate number of results. That's another reason why link in the subnavigation bar should remain as is.

I am not sure, but I imagine another reason that /favorites is faster is due to the difference in how they work. /favorites looks in the appropriate favorites table for the user's user_id, while fav:name performs a regular search for posts by looking for the ID in their fav_string.

As far as the subnavbar link, I agree, and I haven't changed that.

MyrMindservant said:

@Toks
Favorites were one of the substantial performance issues in Danbooru 1. I don't know how the code has changed, maybe they won't cause any problems now, but you should monitor how changes you make will influence server response time.

If you are referring to the addition of the user_id parameter, that shouldn't affect anything negatively - it works the same as viewing your own /favorites does, which, as you mentioned, is faster than fav:name.

Updated

What happened with ordering them by upload date? Both links now show the favourites in the way they were added. Not that big of a deal of course, but I really liked it when they were appearing in the order they were uploaded.

Can anyone post some info on this, as I didn't find anything doing a forum search.

darklord said:

What happened with ordering them by upload date? Both links now show the favourites in the way they were added. Not that big of a deal of course, but I really liked it when they were appearing in the order they were uploaded.

Can anyone post some info on this, as I didn't find anything doing a forum search.

You can just do a fav: search for that. eg. fav:darklord

More info on metatags like that available on help:cheatsheet.

1